Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Migrate irpass::scalarize() after optimize_bit_struct_stores & determine_ad_stack_size #8097

Merged
merged 14 commits into from
May 31, 2023

Conversation

jim19930609
Copy link
Contributor

@jim19930609 jim19930609 commented May 29, 2023

Issue: #

Brief Summary

🤖 Generated by Copilot at 5e824fd

This pull request fixes several bugs and improves the performance and usability of the code generation and IR transformation modules. It affects the files codegen_llvm.cpp, ir_builder.h, compile_to_offloads.cpp, and demote_operations.cpp. It also adds a new header file for the demote_operations transform.

Walkthrough

🤖 Generated by Copilot at 5e824fd

  • Fix bugs in code generation for binary division and right shift operations in codegen_llvm.cpp (link, link)
  • Add missing header file for ConstStmt class in ir_builder.h (link)
  • Modify return type of get_constant method in IRBuilder class to be more general in ir_builder.h (link)
  • Remove redundant call to scalarize pass in compile_to_offloads transform in compile_to_offloads.cpp (link)
  • Add missing argument to full_simplify pass in compile_to_offloads transform in compile_to_offloads.cpp (link)
  • Add new header file for IRBuilder class in demote_operations.cpp (link)
  • Add new logic to handle tensor types in binary operations in demote_operations transform in demote_operations.cpp (link, link, link, link, link, link)
  • Remove redundant logic for tensor types in binary operations in demote_operations transform in demote_operations.cpp (link)
  • Add comment to explain motivation and strategy for demoting power operation in demote_operations transform in demote_operations.cpp (link)

@netlify
Copy link

netlify bot commented May 29, 2023

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit b99b2d6
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6474607d66d9a20008b12922

Copy link
Contributor

@dream189free dream189free left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim19930609 jim19930609 merged commit 7555f30 into taichi-dev:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants